fix: add missing syntax and editor highlighting tokens#32
Open
Dakshx07 wants to merge 1 commit into
Open
Conversation
Author
|
Hi @rinkitadhana ! 👋 Just bumping this to see if you have any initial thoughts or feedback on these syntax/editor highlighting tokens. I'm happy to make any changes or split anything further if needed to get this ready to merge. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves a critical runtime crash in the theme system where syntax highlighting tokens were missing from the
ThemeColorsdefinition.Changes
syntaxandeditorcolor tokens to theThemeColorsinterface.lightThemeanddarkThemeobjects with high-quality hex codes for all code highlighting tokens (keywords, strings, functions, etc.).getPrismTokenColorshas the required data to avoid destructuring errors.Context
As requested by @rinkitadhana in #31, this is an isolated PR containing only the bug fix for immediate merging.